Client/src/Pages/DistributedUptime/Monitors/Components/MonitorTable/index.jsx (1)

65-65: ⚠️ Potential issue

Mom's spaghetti alert: Missing actions implementation!

The TODO placeholder needs to be replaced with actual actions for editing and deleting DU monitors, as mentioned in the PR objectives.

Consider implementing an ActionsMenu component similar to the one used in UptimeDataTable:

-render: (row) => <span>{"TODO"}</span>,
+render: (row) => (
+  <ActionsMenu
+    monitor={row.monitor}
+    isAdmin={isAdmin}
+    updateRowCallback={triggerUpdate}
+    pauseCallback={triggerUpdate}
+  />
+),

Client/src/Pages/DistributedUptime/Create/index.jsx (1)

177-177: ⚠️ Potential issue

Remove console.log and handle form submission properly.

The form's onSubmit handler contains a console.log and doesn't prevent default form submission:

-      onSubmit={() => console.log("submit")}
+      onSubmit={(e) => {
+        e.preventDefault();
+        handleCreateMonitor();
+      }}

Client/src/Features/UptimeMonitors/uptimeMonitorsSlice.js (1)

86-91: 🛠️ Refactor suggestion

Remove unused updatedFields object.

The updatedFields object is defined but never used in the API call, as the entire monitor object is passed instead. This creates dead code.

Apply this diff to remove the unused code:

-			const updatedFields = {
-				name: monitor.name,
-				description: monitor.description,
-				interval: monitor.interval,
-				notifications: monitor.notifications,
-			};

Also applies to: 95-95

Client/src/Utils/NetworkService.js (1)

429-434: 🛠️ Refactor suggestion

Use optional chaining for notifications mapping.

The current implementation could throw if notifications is undefined.

Apply this diff to use optional chaining:

-				notifications &&
-					notifications.map(async (notification) => {
+				notifications?.map?.(async (notification) => {

Client/src/Pages/Uptime/Monitors/Components/UptimeDataTable/index.jsx (1)

25-36: Knees weak, arms heavy: JSDoc needs updating!

The JSDoc documentation still references the title property in the monitors array type definition, but the code now uses name. Let's update the documentation to match the implementation.

 * @param {Array<{
 *   _id: string,
 *   url: string,
-*   title: string,
+*   name: string,
 *   percentage: number,
 *   percentageColor: string,
 *   monitor: {

Client/src/Pages/DistributedUptime/Details/Hooks/useDeleteMonitor.jsx (1)

6-25: Yo dawg, add cleanup and success feedback!

The hook's got some missing pieces that could make it more robust:

1. Add cleanup to prevent state updates after unmount
2. Add success toast notification for better UX

Here's how to level up this code:

 const useDeleteMonitor = ({ monitorId }) => {
 	const [isLoading, setIsLoading] = useState(false);
 	const { authToken } = useSelector((state) => state.auth);
+	const mounted = useRef(true);
+	
+	useEffect(() => {
+		return () => {
+			mounted.current = false;
+		};
+	}, []);
+	
 	const deleteMonitor = async () => {
 		try {
 			setIsLoading(true);
 			await networkService.deleteMonitorById({ authToken, monitorId });
+			if (mounted.current) {
+				createToast({
+					body: "Monitor deleted successfully",
+					type: "success"
+				});
+			}
 			return true;
 		} catch (error) {
-			createToast({
-				body: error.message,
-			});
+			if (mounted.current) {
+				createToast({
+					body: error.message,
+					type: "error"
+				});
+			}
 			return false;
 		} finally {
-			setIsLoading(false);
+			if (mounted.current) {
+				setIsLoading(false);
+			}
 		}
 	};

Client/src/Pages/DistributedUptime/Create/Hooks/useCreateDistributedUptimeMonitor.jsx (1)

6-31: Arms are heavy from carrying unused variables!

The hook needs some cleanup and improvements:

1. Remove unused user variable
2. Add form validation
3. Consider optimistic updates

Here's how to clean it up:

 const useCreateDistributedUptimeMonitor = ({ isCreate, monitorId }) => {
-	const { authToken, user } = useSelector((state) => state.auth);
+	const { authToken } = useSelector((state) => state.auth);
 
 	const [isLoading, setIsLoading] = useState(false);
 	const [networkError, setNetworkError] = useState(false);
+
+	const validateForm = (form) => {
+		if (!form.name?.trim()) {
+			throw new Error('Monitor name is required');
+		}
+		// Add more validation as needed
+	};
+
 	const createDistributedUptimeMonitor = async ({ form }) => {
 		setIsLoading(true);
 		try {
+			validateForm(form);
+
 			if (isCreate) {
 				await networkService.createMonitor({ authToken, monitor: form });
 			} else {
 				await networkService.updateMonitor({ authToken, monitor: form, monitorId });
 			}
 
+			createToast({ 
+				body: `Monitor ${isCreate ? 'created' : 'updated'} successfully`,
+				type: 'success'
+			});
 			return true;
 		} catch (error) {
 			setNetworkError(true);

Server/db/mongo/modules/statusPageModule.js (1)

193-201: Yo, let's get some feedback on those deletions! 💪

The function should return the deletion result to help track how many documents were affected.

Here's how to improve it:

 const deleteStatusPagesByMonitorId = async (monitorId) => {
   try {
-    await StatusPage.deleteMany({ monitors: { $in: [monitorId] } });
+    const result = await StatusPage.deleteMany({ monitors: { $in: [monitorId] } });
+    return result;
   } catch (error) {
     error.service = SERVICE_NAME;
     error.method = "deleteStatusPageByMonitorId";
     throw error;
   }
 };

This way, callers can verify how many status pages were actually deleted.

Client/src/Pages/DistributedUptime/Create/index.jsx (4)

34-40: Add input validation to parseUrl utility.

While the try-catch handles parsing errors, consider adding input validation:

 const parseUrl = (url) => {
+  if (!url || typeof url !== 'string') {
+    return null;
+  }
   try {
     return new URL(url);
   } catch (error) {
     return null;
   }
 };

---

57-62: Add interval validation in form state.

Consider adding validation to ensure interval stays within SELECT_VALUES range:

 const [form, setForm] = useState({
   type: "distributed_http",
   name: "",
   url: "",
-  interval: 1,
+  interval: Math.max(1, Math.min(SELECT_VALUES[SELECT_VALUES.length - 1]._id, 1)),
 });

---

78-93: Add cleanup to useEffect.

Consider adding a cleanup function to handle component unmounting:

 useEffect(() => {
+  let mounted = true;
   if (typeof monitor !== "undefined") {
     const parsedUrl = parseUrl(monitor?.url);
     const protocol = parsedUrl?.protocol?.replace(":", "") || "";
-    setHttps(protocol === "https");
+    if (mounted) {
+      setHttps(protocol === "https");
+    }

     const newForm = {
       name: monitor.name,
       interval: monitor.interval / MS_PER_MINUTE,
       url: parsedUrl.host,
       type: monitor.type,
     };

-    setForm(newForm);
+    if (mounted) {
+      setForm(newForm);
+    }
   }
+  return () => {
+    mounted = false;
+  };
 }, [monitor]);

---

96-129: Enhance error messaging in handleCreateMonitor.

Consider providing more specific error messages:

-      createToast({ body: "Failed to create monitor." });
+      createToast({ 
+        body: isCreate 
+          ? "Failed to create monitor. Please try again or contact support." 
+          : "Failed to update monitor. Please try again or contact support." 
+      });

Server/db/mongo/modules/monitorModule.js (1)

611-620: Enhance filter match stage readability.

The nested match stage could be flattened for better readability.

Consider this alternative structure:

-								{
-									$match: {
-										$or: [
-											{ name: { $regex: filter, $options: "i" } },
-											{ url: { $regex: filter, $options: "i" } },
-										],
-									},
-								},
+								{
+									$match: {
+										$or: [
+											{ name: { $regex: filter, $options: "i" } },
+											{ url: { $regex: filter, $options: "i" } },
+										],
+									},
+								},

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

Client/src/Pages/DistributedUptime/Details/index.jsx (1)

124-138: Yo, let's make this dialog description hit harder than a beat drop! 🎵

The dialog implementation is solid, but we could make the description more specific about what gets deleted.

Here's a suggestion to make it clearer:

-				description="Once deleted, your monitor cannot be retrieved."
+				description="Once deleted, your monitor and all associated checks and data cannot be retrieved."

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro